Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

49348 Enhancement of the detail page functionality - contact person selection for detail page #842

Merged
merged 26 commits into from
Dec 4, 2024
Merged

49348 Enhancement of the detail page functionality - contact person selection for detail page #842

merged 26 commits into from
Dec 4, 2024

Conversation

yeneastgate
Copy link
Contributor

related to #835
changed log:
Add contact person for detail page

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jun 19, 2024
@fredericalpers fredericalpers added this to the v4.25 milestone Jun 19, 2024
@fredericalpers fredericalpers added feature New feature component: property detail page Issue, Pull Request or Discussion related to property detail page labels Jun 19, 2024
@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9738299665

Details

  • 29 of 36 (80.56%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.572%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Renderer/InputModelRenderer.php 0 7 0.0%
Totals Coverage Status
Change from base Build 9693965537: 0.01%
Covered Lines: 8359
Relevant Lines: 10505
💛 - Coveralls

@fredericalpers fredericalpers linked an issue Jul 1, 2024 that may be closed by this pull request
Enhancement of the detail page functionality - contact person selection for detail page #835
Closed
4 tasks
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-4-g89ddc0f1-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11179391641.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v5.4, v5.3 Oct 7, 2024
dai-eastgate and others added 8 commits October 10, 2024 13:35
@fredericalpers
Copy link
Member

Hi @yeneastgate,

It seems there are some conflicts in this pull request. Could you please resolve these conflicts so that we can proceed with testing?

Thank you for your effort!

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Nov 22, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-24-g278e98df-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11969327016.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg removed the deploy test Triggers event to create test version label Nov 25, 2024
@miauzjpg miauzjpg added the deploy test Triggers event to create test version label Nov 25, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-26-gb8ec505b-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12008766150.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

Hi @yeneastgate the selection in the backend always defaults to "Show all contact persons," even though the other setting is saved and only one contact person is displayed as expected. Could you please investigate why it isn't reflecting the saved setting?

@yeneastgate
Copy link
Contributor Author

@fredericalpers I have fixed and tested it. Could you please check again?

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Nov 28, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-31-g3a1ba8b9-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12064670507.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-37-g26c5934e-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12155045355.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-38-g9abc7adb-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12155244467.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg merged commit 169f822 into master Dec 4, 2024
5 checks passed
@miauzjpg miauzjpg deleted the 49348-contact-person-selection-for-detail-page branch December 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.3
Development

Successfully merging this pull request may close these issues.

Enhancement of the detail page functionality - contact person selection for detail page
6 participants
@yeneastgate @coveralls @fredericalpers @miauzjpg @dai-eastgate @pospisk