P#48327(Task) Make contact selectable #88
Conversation
update unit test
make contact type selectable for form
…806-make-contact-selectable � Conflicts: � plugin/Installer/DatabaseChanges.php
|
Thanks! Is it possible to cover more lines with tests? |
…806-make-contact-selectable
|
Hi @jayay, |
|
@hungnc89 Thank you so much! The test is broken, would you please have a look? |
|
@jayay oh sorry. I fixed it |
…806-make-contact-selectable � Conflicts: � tests/TestClassFormModelBuilderDBForm.php
Pull Request Test Coverage Report for Build 1920824450
💛 - Coveralls |
plugin/Installer/DatabaseChanges.php
Outdated
| return $this->_pWPDB->query("ALTER TABLE $tableName | ||
| ADD COLUMN `contact_type` varchar(255) NULL DEFAULT NULL | ||
| "); | ||
| return "CREATE TABLE $tableName ( |
There was a problem hiding this comment.
This looks unstable.
The best way to add a column to the table would be to add it to the CREATE TABLE definition in the method getCreateQueryForms.
Then change this block if ($dbversion == 20) { to
if ($dbversion == 20) {
dbDelta($this->getCreateQueryForms());
$dbversion = 21;
}There was a problem hiding this comment.
The new column literally needs to be added in the method getCreateQueryForms.
|
@jayay I updated to INSERT IGNORE query |
|
@jayay sorry. I fixed it |
vu-vuong-esg
changed the title
vu-vuong-esg
changed the title
…806-make-contact-selectable � Conflicts: � languages/onoffice-for-wp-websites-de_DE.po � plugin/FormPostInterest.php � plugin/FormPostOwner.php � plugin/Gui/AdminPageFormSettingsContact.php � plugin/Installer/DatabaseChanges.php
@hoangdoegs Could you please check the comments and resolve the conflict file? |
…o 13806-make-contact-selectable � Conflicts: � languages/onoffice-for-wp-websites-de_DE.mo
|
@hungnc89 Could you please improve the code coverage? |
…o 13806-make-contact-selectable
…o 13806-make-contact-selectable
I added more tests. Now the coverage has been improved |
|
Comment of Robert Igelmund Requirement: "The user can theoretically set the contact type in the scheduled field in "Form Specific Options" (FO) as well as add it to the "Fields" list (FL) so that it is selectable in the frontend form. This may cause a conflict. This case will probably rarely occur in practice. If there is a conflict, the intended field should win in the FO unless no contact type is selected." The mail to the broker contains in case of conflict the wrong contact type, namely the one selected by the user in the frontend. That means the error from #2752693 is not fixed with version 2.21.0-27-g8d09228b. See also screenshot. |
|
@jayay please help to confirm that the last feedback from Robert is not the WP issue |
|
@nglelinh The screenshot appears to be correct, but sadly, is in German. It depicts the field kind of contact in the e-mail to be different than the kind of contact of the newly created address, which is the behavior @michaelarnold-dev is referring to here: #88 (comment). |
|
@jayay Please check again |
No description provided.