Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

53258 Custom Labels for Address Lists and Address List Detail Page in the onOffice for WP Plugin #913

Merged
merged 14 commits into from
Oct 8, 2024
Merged

53258 Custom Labels for Address Lists and Address List Detail Page in the onOffice for WP Plugin #913

merged 14 commits into from
Oct 8, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Oct 1, 2024 •
edited
Loading

related to #912
changed log:

Update custom labels for address list and address detail

@fredericalpers fredericalpers added feature New feature component: address list Issue, Pull Request or Discussion related to address lists component: adress list detail page Issue & Pull Request or Discussion related to adress list detail page labels Oct 1, 2024
@fredericalpers fredericalpers linked an issue Oct 1, 2024 that may be closed by this pull request
Custom Labels for Address Lists and Address List Detail Page in the onOffice for WP Plugin #912
Closed
2 tasks
@fredericalpers fredericalpers added this to the v5.7 milestone Oct 1, 2024
@fredericalpers fredericalpers added QA Issue or Pull request that is in review deploy test Triggers event to create test version labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-10-g4162e8c1-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11139895243.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

Hi @dai-eastgate ,

Thank you for implementing this feature! Overall, it works well and meets the requirements.

I just noticed a small issue: the label of the last field on the address detail page is always displayed twice. See the phone number example below. Could you please check and fix that?

Everything else looks good. Thanks!

last-label-twice

@dai-eastgate
Copy link
Contributor Author

@fredericalpers I will check and fix it.

@dai-eastgate
Copy link
Contributor Author

@fredericalpers I have fixed it and here is the demo video.

bandicam.2024-10-02.17-16-09-994.mp4

@fredericalpers fredericalpers modified the milestones: v5.7, v5.1.4 Oct 4, 2024
@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-11-g1840480b-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11175291573.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath removed the deploy test Triggers event to create test version label Oct 8, 2024
@andernath andernath added the deploy test Triggers event to create test version label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-16-g6a6d1ba3-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11233144842.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-17-gb93bbdbb-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11233530866.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit 04b89d5 into master Oct 8, 2024
5 checks passed
@andernath andernath deleted the 53258-custom-labels-for-address-lists-and-address-list-detail-page branch October 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: address list Issue, Pull Request or Discussion related to address lists component: adress list detail page Issue & Pull Request or Discussion related to adress list detail page deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.

Custom Labels for Address Lists and Address List Detail Page in the onOffice for WP Plugin
3 participants
@dai-eastgate @fredericalpers @andernath