53667 "Speaking" URL for address detail pages #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericalpers
added
feature
6 tasks
|
Steps to install the approved version:
|
p#119769
andernath
reviewed
Oct 22, 2024
plugin/Utility/AddressRedirector.php
Outdated
There was a problem hiding this comment.
This seems to be exactly to be the same class like Redirector.php
Why didn't you reuse this utility class and maybe extend it for address?
There was a problem hiding this comment.
Sorry, I missed your message.
There was a problem hiding this comment.
@dai-eastgate everything is fine. I didn't publish this review till I finished refactoring. :) You had no chance to react.
ingoKrOffice
approved these changes
Oct 24, 2024
|
Steps to install the approved version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #925
changed log:
Added a plugin setting to enable or disable "Speaking" URLs.
Allowing URLs to include the contact's first name, last name, and company.