Fix missing social meta data settings #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericalpers
added
the
bug
plugin/Gui/AdminPageApiSettings.php
Outdated
| @@ -617,7 +617,7 @@ private function addFormModelCache() | |||
| */ | |||
| private function addFormModelSeparatorFormatSettings(string $pageSlug) | |||
| { | |||
| $groupSlugPaging = 'onoffice-settings'; | |||
| $groupSlugPaging = 'onoffice-thousand-separator'; | |||
There was a problem hiding this comment.
I think we should only change the GroupSlug in addFormModelSocialMetaData. If we change it in addFormModelSeparatorFormatSettings, users who have saved settings might need to save the SeparatorFormat settings again.
andernath
commented
Oct 29, 2024
| $labelSeparatorFormatSettings = __('Separator Format Settings', 'onoffice-for-wp-websites'); | ||
| $labelSeparatorCharacterFormat = __('Thousand Separator Format', 'onoffice-for-wp-websites'); | ||
|
|
||
| $pInputModelSeparatorCharacterFormat = new InputModelOption($groupSlugPaging, 'thousand-separator', | ||
| $pInputModelSeparatorCharacterFormat = new InputModelOption('onoffice-settings', 'thousand-separator', |
There was a problem hiding this comment.
@dai-eastgate 👍 Good Job! :)
|
Steps to install the approved version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different settings shared same groupslug and overwrite eachother