Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54192 Map for address list with pin display and show/hide functionality #960

Conversation

yeneastgate
Copy link
Contributor

@yeneastgate yeneastgate commented Nov 11, 2024

related to #948
changed log:

@fredericalpers fredericalpers added this to the v5.9 milestone Nov 11, 2024
@fredericalpers fredericalpers linked an issue Nov 11, 2024 that may be closed by this pull request
5 tasks
@fredericalpers fredericalpers added component: address list Issue, Pull Request or Discussion related to address lists QA Issue or Pull request that is in review feature New feature labels Nov 11, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Nov 11, 2024
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-15-gd0ee3166-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11780720955.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

Hi @yeneastgate I tested the feature, and unfortunately, it's currently not working as expected. When trying to activate the feature, an error message appears, and the changes cannot be saved.

Could you please take another look?

Error: There was a problem saving the view. Please make sure that the name of the view is unique, even across all address list types.

error1234

@yeneastgate
Copy link
Contributor Author

@fredericalpers Could you please try downgrading the plugin version to 55 to check again? The issue seems to occur only when the wp_oo_plugin_listviews_address table has not been updated.

54192-downgrade-version.mp4

added margin to map and height to openstreet address map
changed class
@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Nov 14, 2024
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-17-gef088640-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11833839145.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-24-gd5b32752-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12005207174.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-24-gd5b32752-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12005255199.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg merged commit 1d1031f into master Nov 25, 2024
8 checks passed
@miauzjpg miauzjpg deleted the 54192-map-for-address-list-with-pin-display-and-show-hide-functionality branch November 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: address list Issue, Pull Request or Discussion related to address lists deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map for address list with pin display and show/hide functionality
3 participants