Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54309 Script Loading issue for onoffice-captchacontrol.min.js when form is placed in the footer #963

Merged
merged 19 commits into from
Dec 5, 2024
Merged

54309 Script Loading issue for onoffice-captchacontrol.min.js when form is placed in the footer #963

merged 19 commits into from
Dec 5, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Nov 19, 2024 •
edited
Loading

related to #952
changed log:

@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour QA Issue or Pull request that is in review component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms labels Nov 19, 2024
@fredericalpers fredericalpers added this to the v5.9 milestone Nov 19, 2024
@fredericalpers fredericalpers linked an issue Nov 19, 2024 that may be closed by this pull request
Script Loading issue for onoffice-captchacontrol.min.js when form is placed in the footer #952
Closed
@BenjaminZekavica BenjaminZekavica added the deploy test Triggers event to create test version label Nov 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-22-g674c1264-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12027423387.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

Hi @dai-eastgate, the fixes for this PR are our highest priority right now, so we’d appreciate it if you could finalize them as soon as possible. This will allow us to review and release the changes quickly. Let us know if you need any assistance!

@andernath andernath added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-28-g15b09629-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12118298087.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-29-g20d0258d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12138913011.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath
Merge branch 'master' into 54309-script-loading-issue-for-onoffice-ca…
bfe3649 
…ptchacontrol.min.js-when-form-is-placed-in-the-footer
@andernath andernath added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-32-gbfe36491-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12155609200.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v5.9, v5.3 Dec 4, 2024
@miauzjpg miauzjpg merged commit 5f2c14c into master Dec 5, 2024
5 checks passed
@miauzjpg miauzjpg deleted the 54309-script-loading-issue-for-onoffice-captchacontrol.min.js-when-form-is-placed-in-the-footer branch December 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behaviour component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.3
Development

Successfully merging this pull request may close these issues.

Script Loading issue for onoffice-captchacontrol.min.js when form is placed in the footer
5 participants
@dai-eastgate @fredericalpers @BenjaminZekavica @andernath @miauzjpg