Use proper stdin options in child_process.spawn() instead of passing a file child.stdin.end() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed
added a commit
that referenced
this pull request
Jul 10, 2013
Use proper stdin options in child_process.spawn() instead of passing a file child.stdin.end()
|
cool, thanks @nkakuev! |
|
@jed, sorry, but this commit actually breaks crx. I was passing private key name instead of its contents to ChromeExtension constructor and that's why child.stdin.end(this.privateKey) wasn't working for me. Sorry once again. Please undo this commit. |
|
undone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a file child.stdin.end() wasn't working in my case, so I decided to rewrite this code in a recommended way.