Fix dark mode appearence provided by tailwindcss-typography #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to official documentation, we need to use "prose-invert" https://github.com/tailwindlabs/tailwindcss-typography?tab=readme-ov-file#adapting-to-dark-mode
|
@Cj-bc is attempting to deploy a commit to the Aftab Alam's projects Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for astro-ink failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks to create
astro-ink! I'm happy to build my blog site based on this style :)While converting my blog site into astro-ink based site, I noticed code block doesn't look pretty on dark mode.
After digging in, I found that we need to use
prose dark:prose-invertinstead ofprose dark:prose-darkto properly support dark theme according to official documentation of tailwindcss-typography.I have my blog page set up with this modification, and looks like it's working. (code block have darker backgrond, inline-code block also have dedicated style, etc)
I also believe that this will fix #55 too.