From 22b52b2ab23508a3aa6df76392f72710aa0df72e Mon Sep 17 00:00:00 2001 From: yair Date: Thu, 23 Jan 2025 19:43:44 +0200 Subject: [PATCH] x64: matmul: bugfix copy B padding calculation --- src/cpu/x64/matmul/brgemm_matmul.cpp | 1 + .../benchdnn/inputs/matmul/harness_matmul_regression_bf16 | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/cpu/x64/matmul/brgemm_matmul.cpp b/src/cpu/x64/matmul/brgemm_matmul.cpp index 0301b525d11..f1568a615d8 100644 --- a/src/cpu/x64/matmul/brgemm_matmul.cpp +++ b/src/cpu/x64/matmul/brgemm_matmul.cpp @@ -1998,6 +1998,7 @@ struct brgemm_matmul_t::brg_matmul_exec_ctx_t { bool packed_sparse_weights() const { return bgmmc_.packed_sparse_weights; } int get_current_K_pad(int current_K_iters) const { + if (current_K_iters % bgmmc_.wei_k_blk == 0) return 0; return bgmmc_.extendable_k ? bgmmc_.wei_k_blk - rnd_up( current_K_iters % bgmmc_.wei_k_blk, vnni_factor) diff --git a/tests/benchdnn/inputs/matmul/harness_matmul_regression_bf16 b/tests/benchdnn/inputs/matmul/harness_matmul_regression_bf16 index e84e403bd74..1588ab1bdf5 100644 --- a/tests/benchdnn/inputs/matmul/harness_matmul_regression_bf16 +++ b/tests/benchdnn/inputs/matmul/harness_matmul_regression_bf16 @@ -17,3 +17,11 @@ --reset --dt=bf16:bf16:bf16 2x1280:1280x65_n"parallel_reduction" + +# Shape to better test k tail. +--reset +--dt=bf16:bf16:bf16 +--stag=ab +--wtag=ab +--dtag=ab +8x2664:2664x256_n"k tails" \ No newline at end of file