Add ability to log from the tracing layer directly rather than use XPTI #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumfare
commented
May 22, 2024
callumfare
force-pushed
the
callum/tracing_logger
branch
from
2639f4c
to
75bfeef
Compare
callumfare
commented
May 22, 2024
pbalcer
reviewed
May 22, 2024
github-actions
bot
added
loader
callumfare
force-pushed
the
callum/tracing_logger
branch
from
75bfeef
to
66706a2
Compare
pbalcer
approved these changes
May 23, 2024
There was a problem hiding this comment.
lgtm, but please add a simple test. Something like the existing hello world tracing test: https://github.com/oneapi-src/unified-runtime/blob/main/test/layers/tracing/CMakeLists.txt#L35
kbenzie
added
ready to merge
|
Also, we might want to document this, right now the tracing layer documentation only lists the xpti entry points. |
pbalcer
approved these changes
May 23, 2024
github-actions
bot
added
the
specification
callumfare
force-pushed
the
callum/tracing_logger
branch
from
8b877c3
to
0eb0f78
Compare
callumfare
force-pushed
the
callum/tracing_logger
branch
from
0eb0f78
to
9d4d091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use the tracing layer with a logger rather than relying on XPTI. The motivation for this is to provide an equivalent to
SYCL_PI_TRACEwhen we remove PI from the SYCL runtime.urtraceandsycl-tracewill still be supported.