Ensure a consistent line-endings policy #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
approved these changes
May 23, 2024
I just went to change one line in a file, then found out the whole file changed since it was committed differently to my local system, and we don't do normalisation yet. This fixes that. Here we add a .gitattributes file at the top level with the policy `* text=auto` which roughly translates as files that git considers "text" are stored internally in history as LF and checked out according to local user preference (which might be CRLF on a certain person's Win32 box, for example). In addition to the new .gitattributes, files that had CRLF line-endings in the history have been renormalized with `git add --renormalize .`. This should make cross-platform development easier while respecting local configs. When in Rome...
|
Since this is functionally NFC, but has the possibility to need rebasing several times would it be possible to please merge soon? |
Yes, as soon as @oneapi-src/unified-runtime-level-zero-write review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just went to change one line in a file, then found out the whole file changed since it was committed differently to my local system, and we don't do normalisation yet. This fixes that.
Here we add a .gitattributes file at the top level with the policy
* text=autowhich roughly translates as files that git considers "text" are stored internally in history as LF and checked out according to local user preference (which might be CRLF on a certain person's Win32 box, for example).In addition to the new .gitattributes, files that had CRLF line-endings in the history have been renormalized with
git add --renormalize ..This should make cross-platform development easier while respecting local configs.
When in Rome...