Add loader API map/def files #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
May 24, 2024
PatKamin
force-pushed
the
loader-map-files
branch
2 times, most recently
from
fc664e8
to
00cb3ae
Compare
pbalcer
approved these changes
May 27, 2024
PatKamin
force-pushed
the
loader-map-files
branch
from
00cb3ae
to
d9f99c2
Compare
|
/e2e-level-zero |
|
E2E L0 build: |
PatKamin
force-pushed
the
loader-map-files
branch
from
d9f99c2
to
f883e86
Compare
kbenzie
force-pushed
the
loader-map-files
branch
2 times, most recently
from
888337d
to
62f9a7c
Compare
PatKamin
force-pushed
the
loader-map-files
branch
from
62f9a7c
to
ca23092
Compare
kbenzie
reviewed
Jun 5, 2024
source/loader/CMakeLists.txt
Outdated
| set_target_properties(ur_loader PROPERTIES | ||
| LINK_FLAGS "/DEF:${LOADER_VERSION_SCRIPT}" | ||
| ) | ||
| else() |
There was a problem hiding this comment.
This should be checking if its Linux:
Suggested change
| else() | |
| elseif(CMAKE_SYSTEM_NAME STREQUAL Linux) |
Export only the loader API symbols that are needed. This is done by creating a map file for the loader API for Linux and a def file for Windows.
PatKamin
force-pushed
the
loader-map-files
branch
from
ca23092
to
de6da74
Compare
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export only the loader API symbols that are needed. This is done by creating a map file for the loader API for Linux and a def file for Windows.
This is to fix the issue of having the same set of symbols exported both by libur_loader and libigc leading to UndefinedBehavior. This issue occurs for UR binaries built with ASan and
DisableDeepBind=1compute-runtime env var set while running a binary.