Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(questions): add image input question type #161

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

pabloelisseo
Copy link
Contributor

Type:

  • CI/CD: helm, docker & CI/CD adjustments.
  • feature: new capabilities.
  • fix: bug, hotfix, etc.
  • refactor: enhancements.
  • style: changes in styles.
  • other: docs, tests.

What's the focus of this PR:

How to review this PR:

Related work items

Before submitting this PR, I made sure:

  • There is no lint error in the code
  • Build process passes successfully
  • There are some tests

Copy link
Contributor

@NuriaExtremadouro NuriaExtremadouro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be stylable enough? Otherwise LGTM!

Copy link

@juanma-dominguez juanma-dominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

src/builder.js Outdated Show resolved Hide resolved
@pabloelisseo
Copy link
Contributor Author

Will it be stylable enough? Otherwise LGTM!

It will be stylable the same way as normal inputs for now. I think it should be enough, at least for DAZN. Later when we add the image previewer we may need to create a varian just for the image_input type

Copy link

@juanma-dominguez juanma-dominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants