Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github action to publish on npm #98

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

Donivanes
Copy link

@Donivanes Donivanes commented Oct 18, 2021

Type:

  • cicd: helm, docker & cicd adjustments.
  • feature: new capabilities.
  • fix: bug, hotfix, etc.
  • refactor: enhacements.
  • style: changes in styles.
  • other: docs, tests.

What's the focus of this PR:

  • Added github action to publish the package on npm.

How to review this PR:

Q: There are still files on the root of the package like .travis.yml, should we remove them?
A: Sure!

Q: Also there are some scripts on the package.json to do releases of the package, how can we adapt them to the github actions?

Q: Important, we need to add the NPM SECRET
A: Done!

@pablo-albaladejo
Copy link
Contributor

LGTM! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants