fix(core): input and textarea borders on focus #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview a1ff6ea has been successfully built and deployed to https://onfido-castor-preview-pr-208.surge.sh 🕐 Build time: 116.702s
🤖 By surge-preview |
rabelloo
force-pushed
the
fix/input-textarea-focus-border
branch
from
73a2327 to
ba60787
Compare
josokinas
approved these changes
Jan 20, 2021
Refactors their styles to be shared in a mixin . That mixin also fixes the border specificity issue, by applying it between and , which requires a line disable.
rabelloo
force-pushed
the
fix/input-textarea-focus-border
branch
from
07872db to
a1ff6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #207
Approach
Refactors their styles to be shared in a mixin
as-text-input.That mixin also fixes the border specificity issue,
by applying it between
:hoverand.-invalid,which requires a
stylelintline disable.Testing
Visually check the borders on focus.
Risks
None.