fix(core): checkbox component "invalid" state styling #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 772e9f3 has been successfully built and deployed to https://onfido-castor-preview-pr-231.surge.sh 🕐 Build time: 125.188s
🤖 By surge-preview |
josokinas
force-pushed
the
fix/checkbox-invalid-styling
branch
from
c49437c to
772e9f3
Compare
josokinas
changed the title
rabelloo
approved these changes
Jan 26, 2021
Checked with @Subcide, everything is fine. Design will be adjusted to reflect such state with having a border, where originally it did not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Styling for Checkbox "invalid" state is not right.
Approach
Fix styling to apply correct "invalid" colors for [checked] and [indeterminate] indicators, also outline.
Testing
On Storybook using "night" mode.
Risks
N/A