feat(core): automatically include field-label (for input/textarea) #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 6d0f6bb has been successfully built and deployed to https://onfido-castor-preview-pr-293.surge.sh 🕐 Build time: 152.982s
🤖 By surge-preview |
rabelloo
approved these changes
Feb 10, 2021
josokinas
force-pushed
the
feat/auto-include-field-label
branch
from
790c8ab to
6d0f6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
FieldLabelis not included withinInputandTextareaautomatically when children are passed (talking about React components here), so CSS should also include styling for such automatically.Approach
Automatically include (only once) CSS for "field-label: component.
Testing
Locally, on Storybook.
Risks
CSS includes also in case label is not used.