fix(core): compile field-label only once #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following #293 main compilation of all components is wrong, as conditional inclusion uses
includes
for keeping a map of what has been included.Approach
Rollback to checking for whether "field-label" was already included.
Another option is to exclude this component from a list of all components completely, however then we might introduce a bug when "field-label" is removed from both "input" and "textarea".
Testing
Tested local build.
Risks
N/A