Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form disabled interactions #456

Merged
merged 2 commits into from
Mar 23, 2021
Merged

fix: form disabled interactions #456

merged 2 commits into from
Mar 23, 2021

Conversation

rabelloo
Copy link
Contributor

Purpose

Fixes an issue where form elements not wrapped by <Field /> wouldn't represent the form disabled state.

Approach

Better merge form and field state in useField, which is the only hook form elements use.

Testing

Storybook.

Risks

None.

@rabelloo rabelloo requested a review from josokinas March 22, 2021 17:22
@rabelloo rabelloo self-assigned this Mar 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021

🎊 PR Preview 3b51258 has been successfully built and deployed to https://onfido-castor-preview-pr-456.surge.sh

🕐 Build time: 210.57s

🤖 By surge-preview

@josokinas josokinas added this to the 1.2.0 milestone Mar 23, 2021
@rabelloo rabelloo merged commit 1ed733b into main Mar 23, 2021
@rabelloo rabelloo deleted the fix/form branch March 23, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants