feat(core): improve font monospace list #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview ef5aaad has been successfully built and deployed to https://onfido-castor-preview-pr-619.surge.sh 🕐 Build time: 142.298s
🤖 By surge-preview |
josokinas
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When "Roboto Mono" is not available, the default
monospacefont in Chrome/MacOS is Courier, which is a serif font and looks nothing like Roboto.So, this improves the monospace list in case "Roboto Mono" isn't available.
Approach
Add
Consolasfor Windows andMenlofor MacOS.Testing
Use monospace font helpers but don't provide "Roboto Mono".
Risks
None.