fix(react): form values onChange and onSubmit #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview e7f4dd7 has been successfully built and deployed to https://onfido-castor-preview-pr-635.surge.sh 🕐 Build time: 192.681s
🤖 By surge-preview |
rabelloo
force-pushed
the
fix/form
branch
3 times, most recently
from
0bf94c4 to
7047e07
Compare
rabelloo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix
Formto read values properly depending on element attributes.Approach
Check for element attributes and resolve value according to each of them.
Testing
Completely revamped the unit test suite.
Manual testing can be done on the story.
Risks
None.