fix(core): use css properties from csstype, do not rely on react #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onfido-oss/castor/7eQiBfzFhGa9qmhd51mCah1a93uA |
Instead of using CSSProperties that require to have React as a
dependency even for a core package,
use from csstype dependency.
fixes #811
josokinas
force-pushed
the
fix/font-interface
branch
from
7d8b5d1 to
b5c4f35
Compare
josokinas
changed the title
rabelloo
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Because a Font type within a helper uses CSSProperties that come from React dependency, a core package also requires React even for those who do not use it (but use TS).
Approach
Instead of using CSSProperties that require to have React as a dependency even for a core package, depend directly on
csstype.Downside - introducing a dependency.
Testing
Everything should still work as previously.
Risks
N/A