Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Quick fix -> Add missing members not working properly #398

Closed
alilloig opened this issue Jul 3, 2024 · 0 comments · Fixed by #423
Closed

[LS] Quick fix -> Add missing members not working properly #398

alilloig opened this issue Jul 3, 2024 · 0 comments · Fixed by #423
Assignees
Labels
Bug The issue represents a bug, malfunction, regression

Comments

@alilloig
Copy link
Member

alilloig commented Jul 3, 2024

Problem

When you use the aforementioned tool for adding e.g. missing functions to a contract or resource, the access modifier is badly constructed. It'll say all fun rather than access(all) fun. It also forgets the view modifier if the function has it.

Steps to Reproduce

This was found updating FungibleToken contracts to Cadence 1.0 and the new FT standard. Just create a contract or resource that implements an interface with any function declared on it, then scroll over its name to get to the vscode popup that shows you the error and allows you to apply the quick fix.

Context

This may be related to onflow/vscode-cadence#563

@alilloig alilloig added the Bug The issue represents a bug, malfunction, regression label Jul 3, 2024
@jribbink jribbink changed the title Quick fix -> Add missing members not working properly [LS] Quick fix -> Add missing members not working properly Jul 3, 2024
@jribbink jribbink transferred this issue from onflow/vscode-cadence Jul 3, 2024
@turbolent turbolent self-assigned this Aug 27, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants