Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync feature/string-templates branch with master #3657

Merged
merged 76 commits into from
Oct 30, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 30, 2024


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

RZhang05 and others added 30 commits October 16, 2024 16:49
Cleanup outdated FT/NFT related contract codes and tests
@SupunS SupunS self-assigned this Oct 30, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/string-templates commit a185a42
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS marked this pull request as ready for review October 30, 2024 19:14
@SupunS SupunS merged commit 4f9e343 into feature/string-templates Oct 30, 2024
7 of 9 checks passed
@SupunS SupunS deleted the supun/update-string-templates branch October 30, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants