Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fcl] Update account proof resolver to only call on authn #1475

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

gregsantos
Copy link
Contributor

Update account proof resolver to only call if no logged in user

Account proof resolver was being called even when a user was already authenticated. This was unnecessary and could
lead to pop up blocking on authz/user-signature requests.

  • Adds check and log warning if resolver is not an async function

@gregsantos gregsantos requested a review from a team as a code owner November 1, 2022 22:05
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

🦋 Changeset detected

Latest commit: ae34daf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/fcl Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants