Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator Feature: Report gas used #12

Open
srinjoyc opened this issue Sep 9, 2021 · 6 comments
Open

Emulator Feature: Report gas used #12

srinjoyc opened this issue Sep 9, 2021 · 6 comments
Assignees
Labels
Local Development Tools Tier 3 Small task, spanning 1 milestone, generally can be completed with limited domain knowledge.

Comments

@srinjoyc
Copy link
Contributor

srinjoyc commented Sep 9, 2021

👋   If you are interested in working on this issue, please check out the Getting Started guide on HackerEarth!

Description (Problem Statement)

There should be a way to see transaction gas (computation) usage.

Gas usage is not the same as transaction fees. Transaction fees are currently static, but in the future they will depend on the gas used by the transaction.

Executed transactions are currently logged like this (when in verbose mode):

image

The transaction executed line should also include gas usage.

To get the gas usage of the transaction, you can get started here. This field gets filled after the transaction is run. This information should be intercepted on the emulator.

Experience Required

  • Experience with Go
  • Some understanding of the Flow's architecture

Minimum Feature Set (Acceptance Criteria)

  • When executing a transaction in the emulator gas usage should be visible in the emulator logs

Software Requirements

Maintainability

  • The tools or libraries used to construct the solution should be well vetted and well maintained
  • Code should be written in a way where it's easily extensible to new functionality and semantic enough for open-source developers to contribute to.

Testing

  • Wherever possible unit tests should be written
  • Meet testing guidelines of the repo

Other Requirements

Documentation

  • Edit the current documentation to add a description of this new feature

Code standards or guidelines

Judging Criteria

Resources

@srinjoyc srinjoyc added Tier 3 Small task, spanning 1 milestone, generally can be completed with limited domain knowledge. Local Development Tools labels Sep 9, 2021
@psiemens psiemens changed the title Emulator Feature: Report Gas Used Emulator Feature: Report gas used Sep 15, 2021
@sideninja
Copy link
Contributor

Hi 👋
my name is Gregor, and as a software engineer working on developer tools, I will be your point of contact for this task, so good luck, and don't hesitate to reach out to me with any problems or questions.

I'll keep an eye on your progress and will be reviewing your code.

You can comment here or find me on Discord (I'm sideninja#1970). Join the Flow Discord server if you're not there already!

@avcdsld
Copy link
Contributor

avcdsld commented Sep 26, 2021

Hi

  1. Team: https://www.hackerearth.com/challenges/hackathon/flip-fest/dashboard/c511683/team/
  2. @avcdsld (There are three of us on the team, but I'm the only one participating in this issue.)
  3. plan time: 2021-09-26

@avcdsld
Copy link
Contributor

avcdsld commented Sep 26, 2021

Hi @sideninja
I have created a PR for this issue, can you please check it? Please let me know if any corrections need to be made.
I am glad to have had this opportunity.
onflow/flow-emulator#87

@sideninja
Copy link
Contributor

sideninja commented Sep 29, 2021

@avcdsld Your PR has been accepted and merged, since this was a task that has obvious correct implementation it has been merged. Existing PR here: onflow/flow-emulator#87

--

If you believe you have a revolutionary better idea on how to implement this you are always free to do so, but we believe this task is too small to have many other approaches.

@kimcodeashian
Copy link

kimcodeashian commented Nov 12, 2021

Good day @avcdsld!

Thanks so much for all your hardwork & participation. In order to finalize winners & prepare for prize payout, we'll need the following actions from your end.

Please provide the following information by Nov 17, 2021, (in this GH Issue is fine):

1. Team Information

  • Team Members Information - Github Username + Email Contact + Percentage of prize allocation (total should = 100%)
  • All mentioned members MUST react to the post with a 👍 which will act as confirmation that the information is correct, or a 👎 to indicate that the information is not correct.
  • We will be reaching out via e-mail

🎖IMPORTANT: We will only proceed with prize payouts once all members have confirmed with 👍 on the post.

2. Video Demo (optional)

  • Please provide a 5-minute video demo to be featured & showcased in the FLIP Fest Closing Ceremonies
  • Link format & Downloadable (eg. Google Drive, Vimeo)
  • Content Format (Problem Statement, your work / how you solved it, final outcome)

We will be hosting Closing Ceremonies on November 23rd, 8AM PT where we'll having closing remarks from Dete & will be announcing the winners! I'll share the details here before Nov 17.

@kimcodeashian
Copy link

Hey folks,

We've received and reviewed over 82 submissions! What an amazing community on Flow! To commemorate all the hard work done, we have finalized winners and will be announcing them during our Closing Ceremony on Nov 23rd, 8AM PT. Be sure to join us - there may be some attendance prizes & a keynote from our CTO, Dete 😉!

RSVP here so you don't miss out! See you then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Local Development Tools Tier 3 Small task, spanning 1 milestone, generally can be completed with limited domain knowledge.
Projects
None yet
Development

No branches or pull requests

4 participants