Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution State] Add extra logging in execution node #2074

Closed
fxamacker opened this issue Feb 25, 2022 · 0 comments · Fixed by #2119
Closed

[Execution State] Add extra logging in execution node #2074

fxamacker opened this issue Feb 25, 2022 · 0 comments · Fixed by #2119
Assignees
Labels
Execution Cadence Execution Team Improvement

Comments

@fxamacker
Copy link
Member

fxamacker commented Feb 25, 2022

Problem

Some error(s), warnings, and other useful information are not currently logged.

Examples:

  • It can be useful to log CPU info (model, family, logical cores, etc.) for various reasons. If EN specs fluctuate between Broadwell and Cascade Lake with substantial GHz difference, then having that info can be useful when deploying optimizations and making comparisons to past performance.
  • It can be useful to log a warning if some activity based on dynamic or stored data is going to use a suspiciously large percent of total installed RAM. If we ever run out of RAM, then such a log can help us save time investigating crash loops, etc.
  • There's at least one error not logged which was noticed during PR #1944 but it's out of scope for that PR and located outside checkpoint code.

The Proposed Solution

  • Log some useful info (e.g. cpu info), warnings (see above), and errors.
  • Avoid spamming the log with noise.
@fxamacker fxamacker self-assigned this Feb 25, 2022
@fxamacker fxamacker changed the title Add extra logging in execution node [Execution State] Add extra logging in execution node Feb 28, 2022
@fxamacker fxamacker added the Execution Cadence Execution Team label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant