Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager generates unexpected number of available pages #255

Open
einorler opened this issue Jul 19, 2018 · 2 comments
Open

Pager generates unexpected number of available pages #255

einorler opened this issue Jul 19, 2018 · 2 comments

Comments

@einorler
Copy link
Member

In certain circumstances the pager can display more pages than it normally should. The problem lies here:

$end = $begin + $this->maxPages - 2;

The problem here is that here $end can be more than the maximum number of available pages if the $this->maxPages parameter is higher than 4

@khusseini
Copy link

I also noticed, that the pagination always shows 8 pages, no matter how many results were returned. Even if no results are present

@khusseini
Copy link

I noticed that this was fixed in the 2.1 branch, however if you like me cannot use that version due to version conflicts in dependencies you can try the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants