Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks reproductability #1304

Closed
killianLM opened this issue Aug 4, 2023 · 1 comment · Fixed by #1308
Closed

Benchmarks reproductability #1304

killianLM opened this issue Aug 4, 2023 · 1 comment · Fixed by #1308

Comments

@killianLM
Copy link
Contributor

Hey there,

I am opening this issue concerning the Benchmarks part of River for a few reasons:

  • First of all, it currently seems hard to reproduce. I've had multiple issues with it, especially with dependencies, as I had a few dependencies not installing properly (or at all) such as vowpalwabbit. I also had issues with the functionalities of tqdm, where I was forced to remove its use in the run.py file.
  • Second, it does not look fully up to date to the latest version of River. For example, the current version of benchmarks calls ensemble.AdaptiveRandomForestClassifier, which does not exist in the current version of River.

In our opinion, it is important that this benchmark be easily reproductible as soon as it is installed, both from a purely scientific point of view, and to have a very useful global test of non regression.
All in all, it looks like it has a few issues, including ease of use, which would benefit from your attention.

Have a good day,
Killian.

@MaxHalford
Copy link
Member

Hey there @killianLM. Yes, I totally agree with you on both points. However, the attitude to have in the open source world is not just to point and call out what's wrong. We have limited spare time to work on River, because we have jobs on the side. In this case, why don't you share what exactly is going wrong? What Python exceptions are you facing? More than that, I encourage you to fix stuff yourself if you notice it.

Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants