From d6a01e55c508d0f0e1c258353ddea98463ae0a7d Mon Sep 17 00:00:00 2001 From: Ravjot Singh Samra Date: Mon, 8 Jul 2024 04:44:59 +1200 Subject: [PATCH 1/2] Fixed `AttributeError` in metrics/roc_auc.py. `scipy.integrate.trapezoid` replaced `scipy.integrate.trapz` in SciPy. --- river/metrics/roc_auc.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/river/metrics/roc_auc.py b/river/metrics/roc_auc.py index 3e7f780564..2f439d091b 100644 --- a/river/metrics/roc_auc.py +++ b/river/metrics/roc_auc.py @@ -100,4 +100,10 @@ def safe_div(a, b): tprs[i] = safe_div(a=tp, b=tp + fn) fprs[i] = safe_div(a=fp, b=fp + tn) - return -integrate.trapz(x=fprs, y=tprs) + trapezoid = ( + integrate.trapz # For older/outdated versions of SciPy. + if hasattr(integrate, "trapz") + else integrate.trapezoid + ) + + return -trapezoid(x=fprs, y=tprs) From 29870a47202da4c27e668de32feaa4ee6d266576 Mon Sep 17 00:00:00 2001 From: Ravjot Singh Samra <31635233+RavSS@users.noreply.github.com> Date: Sat, 20 Jul 2024 03:14:08 +1200 Subject: [PATCH 2/2] Always use `integrate.trapezoid`. --- river/metrics/roc_auc.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/river/metrics/roc_auc.py b/river/metrics/roc_auc.py index 2f439d091b..c3d6604f00 100644 --- a/river/metrics/roc_auc.py +++ b/river/metrics/roc_auc.py @@ -100,10 +100,4 @@ def safe_div(a, b): tprs[i] = safe_div(a=tp, b=tp + fn) fprs[i] = safe_div(a=fp, b=fp + tn) - trapezoid = ( - integrate.trapz # For older/outdated versions of SciPy. - if hasattr(integrate, "trapz") - else integrate.trapezoid - ) - - return -trapezoid(x=fprs, y=tprs) + return -integrate.trapezoid(x=fprs, y=tprs)