Use ko for progress background color #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant2002
requested changes
Apr 5, 2018
js/pages/tablespage.ts
Outdated
|
|
||
| constructor(private commandExecutor: ICommandExecutor) { | ||
| super(); | ||
| const self = this; | ||
| this.slideWidth = ko.observable(0); | ||
| this.isConnectionSlow = ko.observable(false); | ||
| this.calculateLandscapeWidth(); | ||
| this.progressBackgroundColor = ko.observable($(".progress-background").css("background-color")); |
There was a problem hiding this comment.
This value should be taken from configuration. No need to use jQuery.
There was a problem hiding this comment.
From what configuration? Do you mean that i should store variable rgba(0,0,0,.75) in appConfig ?
js/pages/tablespage.ts
Outdated
| $(".progress-background").css("background-color", "black"); | ||
| timeService.setTimeout(() => { | ||
| app.processing(false); | ||
| $(".progress-background").css("background-color", oldColor); | ||
| $(".progress-background").css("background-color", this.progressBackgroundColor()); |
There was a problem hiding this comment.
Here should be just updating progressBackgroundColor. No jQuery, Knockout should take care of updates
There was a problem hiding this comment.
So i should change main project then and add style binding for all .progress-background ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #139