Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make TablesPage and SeatPage too smart #45

Open
kant2002 opened this issue Nov 13, 2017 · 3 comments
Open

Don't make TablesPage and SeatPage too smart #45

kant2002 opened this issue Nov 13, 2017 · 3 comments

Comments

@kant2002
Copy link
Contributor

Right now TablePage and SeatPage are have a lot of reference to current table, like roundNotificationCaption, changeBetParametersNextGame and so on This unnecessary make TableView tightly coupled with TablePage and SeatPage. It is better remove such properties and change UI in such way, that each TableView could be presented independenctly and TablePage will prowide only shell for displaying and switching between TableView.

@mtutynina
Copy link
Contributor

Shoud we remove ALL tableview references?
loading
frozen
opened
nextGameInformation
nextGameTypeInformation
changeBetParametersNextGame
changeGameTypeNextGame

@kant2002
Copy link
Contributor Author

First we should stop adding new properties, and remove recently added. Then other should be checked on the individual basis. You should always keep in mind that this is same code would be used in the mobile application version for some online product.

@mtutynina
Copy link
Contributor

Ok, then for a start i'll remove changeGameTypeNextGame and nextGameTypeInformation as it was made several weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants