Increment sequence_number after failure #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an sendSMS submission returns a legitimate exception (i.e. `$response->status != SMPP::ESME_ROK`), the sequence_number isn't incremented. This casues the SMSC to fail all subsequent messages as the sequence number is the same as the original failed submission. The incrementing of sequence_number on line 624 of smppclient.class.php should be moved prior to the exception on line 622. If the class supported resubmission attempts this sequence_number should probably not be incremented however as this feature isn't supported, we should just increment it and move on.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an sendSMS submission returns a legitimate exception (i.e.
$response->status != SMPP::ESME_ROK), the sequence_number isn't incremented. This casues the SMSC to fail all subsequent message submissions as the sequence number is the same as the original failed submission.The incrementing of sequence_number on line 624 of smppclient.class.php should be moved prior to the exception on line 622.
If the class supported resubmission attempts this sequence_number should probably not be incremented however as this feature isn't supported, we should just increment it and move on.