Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment sequence_number after failure #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increment sequence_number after failure #44

wants to merge 1 commit into from

Commits on May 13, 2015

  1. Increment sequence_number after failure 

    After an sendSMS submission returns a legitimate exception (i.e. `$response->status != SMPP::ESME_ROK`), the sequence_number isn't incremented. This casues the SMSC to fail all subsequent messages as the sequence number is the same as the original failed submission.

The incrementing of sequence_number on line 624 of smppclient.class.php should be moved prior to the exception on line 622.

If the class supported resubmission attempts this sequence_number should probably not be incremented however as this feature isn't supported, we should just increment it and move on.
    Nick Adams committed May 13, 2015
    Configuration menu
    Copy the full SHA
    809ae93 View commit details
    Browse the repository at this point in the history