New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of 0-length messages #52

Open

danon wants to merge 2 commits into onlinecity:master from danon:master

danon commented Aug 6, 2015 •

edited

Loading

SmppSms $sms;
$sms->parseSms(); // goes nuts when MessageLength byte is equals to 0

It's also against specification, which states:

The maximum message length which can be specified in sm_length field (see section 5.2.21) is 254 octets. If an ESME wishes to submit a message of length greater than 254 octets, the sm_length field must be set to NULL and the message_payload optional parameter must be populated with the message length value and user data.

danon added 2 commits

August 6, 2015 14:44


          Can now handle 0-length messages.

ee62202


          Better problem description

b239852

danon mentioned this pull request

your lib can't handle empty messages #51

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet