From 26eea013cbafdec66e1385cde033c3c105a3d020 Mon Sep 17 00:00:00 2001 From: Jacob Date: Fri, 10 Nov 2023 14:29:22 +0100 Subject: [PATCH] # 1296 fix(precompiled test guite): exec bit check omitted on Windows (#1301) Co-authored-by: Jacob Grieger --- ginkgo/internal/test_suite.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ginkgo/internal/test_suite.go b/ginkgo/internal/test_suite.go index 64dcb1b78..f3ae13bb1 100644 --- a/ginkgo/internal/test_suite.go +++ b/ginkgo/internal/test_suite.go @@ -7,6 +7,7 @@ import ( "path" "path/filepath" "regexp" + "runtime" "strings" "github.com/onsi/ginkgo/v2/types" @@ -192,7 +193,7 @@ func precompiledTestSuite(path string) (TestSuite, error) { return TestSuite{}, errors.New("this is not a .test binary") } - if filepath.Ext(path) == ".test" && info.Mode()&0111 == 0 { + if filepath.Ext(path) == ".test" && runtime.GOOS != "windows" && info.Mode()&0111 == 0 { return TestSuite{}, errors.New("this is not executable") }