From 90d4846e63cf95e9100b16eb3ff537494f3fb0a0 Mon Sep 17 00:00:00 2001 From: Erik Schubert Date: Tue, 19 Sep 2023 14:13:10 +0200 Subject: [PATCH] Print logr prefix if it exists (#1275) --- internal/writer.go | 6 +++++- internal/writer_test.go | 6 ++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/internal/writer.go b/internal/writer.go index 574f172df..aab42d5fb 100644 --- a/internal/writer.go +++ b/internal/writer.go @@ -135,6 +135,10 @@ func (w *Writer) Println(a ...interface{}) { func GinkgoLogrFunc(writer *Writer) logr.Logger { return funcr.New(func(prefix, args string) { - writer.Printf("%s\n", args) + if prefix == "" { + writer.Printf("%s\n", args) + } else { + writer.Printf("%s %s\n", prefix, args) + } }, funcr.Options{}) } diff --git a/internal/writer_test.go b/internal/writer_test.go index bb4941206..0c7de5df6 100644 --- a/internal/writer_test.go +++ b/internal/writer_test.go @@ -144,5 +144,11 @@ var _ = Describe("Writer", func() { log.Error(errors.New("cake"), "planned failure", "key", "banana") Ω(string(out.Contents())).Should(Equal(" \"level\"=0 \"msg\"=\"message\" \"key\"=5\n \"msg\"=\"planned failure\" \"error\"=\"cake\" \"key\"=\"banana\"\n")) }) + + It("can print the logr prefix", func() { + log := internal.GinkgoLogrFunc(writer) + log.WithName("berry").Info("message", "key", 5) + Ω(string(out.Contents())).Should(Equal(" berry \"level\"=0 \"msg\"=\"message\" \"key\"=5\n")) + }) }) })