From b56269baa96bf193be23330a595c09a285a840b7 Mon Sep 17 00:00:00 2001 From: Onsi Fakhouri Date: Wed, 3 May 2023 08:51:22 -0600 Subject: [PATCH] remove accidental TODO commit --- TODO | 60 ------------------------------------------------------------ 1 file changed, 60 deletions(-) delete mode 100644 TODO diff --git a/TODO b/TODO deleted file mode 100644 index 8a44c4b69..000000000 --- a/TODO +++ /dev/null @@ -1,60 +0,0 @@ -# Backlog -[] @G fix hang with ginkgo -p - https://github.com/onsi/ginkgo/issues/1192 -[] @B biloba needs to support "McDonald's" -[] @G Document order of execution for setup nodes on the same level - https://github.com/onsi/ginkgo/issues/1172 -[] @G fail fast may cause Serial spec or cleanup Node interrupted - https://github.com/onsi/ginkgo/issues/1178 - -# Needs-Prioritization -[] @G Pull JUnit config out of code and into flags/config files - https://github.com/onsi/ginkgo/issues/1115 -[] @G -exec support for `ginkgo run` - https://github.com/onsi/ginkgo/issues/869 -[] @G Add `indent` to gcustom -[] @G HaveField should not panic in FailureMessage if the field is non-existant. It should return a meaningful failure message. -[] @G allow NodeTimeout and GracePeriod to live on containers and propagate down -[] @G Clean up ReportEntry decoding: - func (entry ReportEntry) DecodeValue(p interface{}) error { - // if raw is assignable to p, assign - // else - parse AsJSON - } -[] @B Biloba lets you get all innerHTML and emit it on failure -[] @B equivalent of puppeteer text selector? -[] @B how do we invoke async functions? what does await look like for those? maybe time to actually read? goal: remove the separate muhasibPostLogin function. -[] @B https://github.com/onsi/biloba/issues/2 -[] @B right now polling an element fails if the browser if ollowing redirects. so i'm using Eventually(b.Location) - instead of just Eventually("#el").Should(b.Exist()). I think we need a more robust way to ensure biloba. -[] @B biloba support for gettign "SelectedOption" instead of just "Value" for select inputs (e.g. b.OptionByName(...) instead of value?) -[] @B ginkgo interrupt should not show the whole stacktrace. it's just too much! -[] @B add cookie support - chromedp.Run(b.Context, chromedp.ActionFunc(func(ctx context.Context) error { - return storage.ClearDataForOrigin("*", "all").Do(ctx) - })) - - chromedp.Run(b.Context, chromedp.ActionFunc(func(ctx context.Context) error { - expr := cdp.TimeSinceEpoch(time.Date(2091, 28, 3, 1, 40, 45, 0, time.UTC)) - return storage.SetCookies([]*network.CookieParam{{ - Name: "rallly-session", - Value: "Fe26.2*1*66a5cae1dd8728fc7be37a1a3c485557606e526b16b472329be78168ad4d48c2*Yb_O9pN2K3APF6LXt9S3zg*IZQ_c5aukJzt-AIW__lL19igVhpFMGH9cK0PyFenF-2ti94BgBsLDf325DB2rsKE*3825906104968*a06f3cfe6ef65db1a30b5177cb767c914ca38c8fc3e2456de89d5bea5641611e*6HNCfDeEzgfeQO88IRJ8TfdG5IDzDQtt6WaoGAg5i98~2", Expires: &expr, - Domain: "rallly.co", - Path: "/", - HTTPOnly: true, - Secure: true, - SameSite: network.CookieSameSiteLax, - }}).WithBrowserContextID(b.BrowserContextID()).Do(ctx) - })) -[] @Ω Gomega should have an error returning mode, then tell pohly -[] @Ω Gomega submatcher description interface and bare-element interface (the former for any sort of matcher that takes a submatcher; the latter specifically for matchers like Consistently etc. that would replace equalMatchersToElements. - - -[] @B JSSelector (is a function that returns one or many nodes) -[] @B ScrollTo etc. -[] @B support for esbuild? or something? consider the auth_login_scripts tests - what might make them better? - -# Long-term Backlog -- VSCode Extension -- Ginkgo WebView -- Suite configuration -- Suite parallelization - - With the special subcase of supporting shared singleton resources