-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logr.LogSink for GingkoWriter #1063
Comments
I think I'm following. Would the idea be to provide a struct that wraps |
Yes, some // next, err := op.Transition(plugin.Parameters{Log: logr.Discard()}, &Data{})
next, err := op.Transition(plugin.Parameters{Log: GinkgoLogr{}}, &Data{}) |
ah ok, got it - and you'd want it in Ginkgo proper so you could avoid having to pass in |
I would like to have a When I set |
👍 if you're up for working on a PR I'd be happy to pull something in. |
Hey 👋,
I use logr in some projects and use Ginkgo for testing. GingkoWriter offers the option to record some output of failing test. Implementing
LogSink
allows failing Ginkgo tests to outright record what is to be logged anyway, which helps investigating the cause. Adding the glue code would be convenient.Instead of implementing
LogSink
directly, the implementation could be wrapped in an other struct. As I have a basic implementation around, I may work on this.The text was updated successfully, but these errors were encountered: