Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document order of execution for setup nodes on the same level #1172

Closed
Airblader opened this issue Mar 29, 2023 · 1 comment
Closed

Document order of execution for setup nodes on the same level #1172

Airblader opened this issue Mar 29, 2023 · 1 comment

Comments

@Airblader
Copy link

There currently is documentation for the order of execution of something like

Describe("", func() {
	BeforeEach(beforeEach1)

	Describe("", func() {
		BeforeEach(beforeEach2)
	})
})

However, I couldn't find any documentation on whether the execution order is defined for nodes on the same level:

Describe("", func() {
	BeforeEach(beforeEach1)
	BeforeEach(beforeEach2)
})

It would be nice to explicitly document whether Ginkgo makes any guarantees here (and if so, which).

@onsi
Copy link
Owner

onsi commented Apr 6, 2023

hey @Airblader - yes good point. I'll add updating the docs on this point to my todo list. There is a guaranteed order - nodes in outer containers always run before inner containers and nodes within the same container always run in the order in which they are called.

@onsi onsi closed this as completed in 903be81 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants