-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] File Handler Leak #1308
Comments
In case of error at: ginkgo/reporters/json_report.go Line 62 in 3b2a2a7
Handler: ginkgo/reporters/json_report.go Line 56 in 3b2a2a7
won't be freed on: ginkgo/reporters/json_report.go Line 64 in 3b2a2a7
|
hey there - thanks for catching for this. can you submit a PR? |
Yes, of course |
In case of error at line:
ginkgo/reporters/json_report.go
Line 23 in 3b2a2a7
Handler:
ginkgo/reporters/json_report.go
Line 17 in 3b2a2a7
won't be freed on
ginkgo/reporters/json_report.go
Line 27 in 3b2a2a7
Solution:
Replace - return f.Close() with return 0
Add defer f.Close at line 20
The text was updated successfully, but these errors were encountered: