[Bug] File Handler Leak

[stasos24]

In case of error at line:

ginkgo/reporters/json_report.go

Line 23 in 3b2a2a7

err = enc.Encode([]types.Report{

Handler:

ginkgo/reporters/json_report.go

Line 17 in 3b2a2a7

f, err := os.Create(destination)

won't be freed on

ginkgo/reporters/json_report.go

Line 27 in 3b2a2a7

return err

Solution:
Replace - return f.Close() with return 0
Add defer f.Close at line 20

[stasos24]

In case of error at:

ginkgo/reporters/json_report.go

Line 62 in 3b2a2a7

err = enc.Encode(allReports)

Handler:

ginkgo/reporters/json_report.go

Line 56 in 3b2a2a7

f, err := os.Create(destination)

won't be freed on:

ginkgo/reporters/json_report.go

Line 64 in 3b2a2a7

return messages, err

[onsi]

hey there - thanks for catching for this. can you submit a PR?

[stasos24]

hey there - thanks for catching for this. can you submit a PR?

Yes, of course
#1309