-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ginkgo v2 leaks goroutine #1364
Comments
yes - there are goroutines that outlive each individual spec and that outlive the entire test. the fix you propose would fix the leak that outlives the entire test. fwiw - you may want to use |
@onsi thanks for a quick response and advice about However, as far as I understood there is no need for the interrupt handler goroutine to outlive the whole suite. Thus, this is a good idea to change this behaviour. Can you confirm that? |
yes that’s also correct - if you want to submit a PR please do |
How to reproduce:
It looks like the following diff can fix this problem:
Though, I'm not sure if this is the best way to do it.
The text was updated successfully, but these errors were encountered: