-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit after certain time has gone by #248
Comments
@jchauncey sounds like a reasonable request. I imagine if you wanted to submit a PR we would probably merge that - we don't currently have the resources to do that ourselves. If you're interested in submitting a PR, let us know and @onsi or I can guide you as to what you might want to look at. |
@robdimsdale I would like to give a shot but I am a newbie. Any references would be great |
Thanks, @sivagollapalli I would probably add a flag called I would suggesti that its value could be an int (seconds) or a string that golang can parse. The latter is probably better. As far as the implementation, I would expect the actual timeout logic to live in https://github.com/onsi/ginkgo/blob/master/ginkgo/suite_runner.go. I suspect we would want a There's an interesting question as to whether This is all high-level, and @onsi might have some design thoughts here too. If you decide to contribute please feel free to reach out for further guidance. |
I would like the tests to exit if they take longer than say 5 minutes to complete. I know this functionality exists in
go test
but doesn't seem to exist inginkgo
The text was updated successfully, but these errors were encountered: