Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use the go help packages package spec #278

Closed
squeedee opened this issue Jul 29, 2016 · 2 comments
Closed

Why not use the go help packages package spec #278

squeedee opened this issue Jul 29, 2016 · 2 comments

Comments

@squeedee
Copy link
Contributor

When writing #277 I realised it's inconsistent for ginkgo to use -r and/or requiring the packages listed out as though they are import statements.

So why did you eschew the packages spec (go help packages?)
I can understand that it's not fun to implement, but I was curious for your feelings about it.

@ches
Copy link

ches commented Aug 6, 2016

This confused me too. Concretely, trying my first gexec spec:

$ go test ./cmd/...
ok      github.com/go-kafka/connect/cmd/kafka-connect   1.993s

$ ginkgo ./cmd/...
Found no test suites
For usage instructions:
        ginkgo help

$ ginkgo -r ./cmd/...
Found no test suites
For usage instructions:
        ginkgo help

$ ginkgo -r ./cmd
Running Suite: kafka-connect CLI Suite
======================================
Random Seed: 1470468089
Will run 1 of 1 specs

•
Ran 1 of 1 Specs in 2.004 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped PASS

Ginkgo ran 1 suite in 4.437792501s
Test Suite Passed

@onsi
Copy link
Owner

onsi commented Jun 3, 2017

I believe this is now fixed

@onsi onsi closed this as completed Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants