Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to watch everything, not just the go files? #356

Closed
aubm opened this issue May 30, 2017 · 2 comments
Closed

Is there a way to watch everything, not just the go files? #356

aubm opened this issue May 30, 2017 · 2 comments

Comments

@aubm
Copy link

aubm commented May 30, 2017

I have this use case because I have a bunch of external test files that contain thing like JSON snippets, etc...
@onsi
Copy link
Owner

onsi commented Jun 1, 2017 •
edited

Sure - this would be a new feature but not too hard. Can you do me a favor?

Can you:

  1. Locally, edit this line and make the RegExp more permissive.
  2. Recompile the Ginkgo CLI (go install github.com/onsi/ginkgo/ginkgo)
  3. Run ginkgo watch and see if you're getting the behavior you desire.

If so I'll probably add a new flag to ginkgo watch that allows you to specify a custom regexp.

@onsi
Copy link
Owner

onsi commented Jun 1, 2017

(Or, if you're comfy, a PR would be great too!)

@onsi onsi added this to To Do in Is this thing on? Jun 1, 2017
@onsi onsi removed this from To Do in Is this thing on? Jun 1, 2017
@onsi onsi closed this as completed in 15a58d2 Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onsi @aubm