Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginkgo should support sending coverage reports directly to coveralls.io #66

Closed
onsi opened this issue Apr 29, 2014 · 7 comments
Closed
Assignees
Milestone

Comments

@onsi
Copy link
Owner

onsi commented Apr 29, 2014

Something like:

ginkgo -cover -coverallsToken=YOUR_TOKEN -coverallsService=travis

@onsi onsi self-assigned this Apr 29, 2014
@onsi onsi added this to the Version 1.1 milestone Apr 29, 2014
@onsi
Copy link
Owner Author

onsi commented Jul 8, 2014

changing my mind on this...

@onsi onsi closed this as completed Jul 8, 2014
@zachgersh
Copy link

@onsi - I'd actually love to know the why behind the decision change. I know quite a few projects outside of our use cases that actually like to use coverage reports.

I'd be happy to put something together on this unless you think there is something super complex here?

@robdimsdale
Copy link
Contributor

Reopening as it looks like there's some community interest. @zachgersh can you provide a highlight of what you'd like to do in a PR?

@robdimsdale robdimsdale reopened this Mar 15, 2016
@zachgersh
Copy link

So, coming back to this:

Currently uploading coverage reports for go is not simple. You need two tools and it just seems like a bit of a mess to get everything running correctly :/

The two other tools you need in addition to the go coverage tool are:
github.com/modocache/gover
github.com/mattn/goveralls

It would be so much easier for people to be able to simple do something like this in ginkgo

COVERALLS_TOKEN=test ginkgo -cover

Ginkgo would then handle collecting all of the various coverage files and uploading them straight to coveralls.io. Existence of the COVERALLS_TOKEN dictates whether or not the coverage report is uploaded (I am fine with this being a flag as well).

cc @robdimsdale @onsi

@robdimsdale
Copy link
Contributor

@zachgersh there's a fair bit of community interest so if you want to submit a PR I think it would be welcome.

What changes do you propose to make to ginkgo to achieve your goals above?

@james-lawrence
Copy link
Contributor

not a huge fan of this honestly, too tightly coupled with coveralls/gover. I'd be more interested in something that combines the individual cover reports and outputs a single file.

@robdimsdale
Copy link
Contributor

We haven't had any activity on this thread in six months - I'm closing it (again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants