-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ginkgo should support sending coverage reports directly to coveralls.io #66
Comments
changing my mind on this... |
@onsi - I'd actually love to know the I'd be happy to put something together on this unless you think there is something super complex here? |
Reopening as it looks like there's some community interest. @zachgersh can you provide a highlight of what you'd like to do in a PR? |
So, coming back to this: Currently uploading coverage reports for go is not simple. You need two tools and it just seems like a bit of a mess to get everything running correctly :/ The two other tools you need in addition to the go coverage tool are: It would be so much easier for people to be able to simple do something like this in ginkgo
Ginkgo would then handle collecting all of the various coverage files and uploading them straight to coveralls.io. Existence of the COVERALLS_TOKEN dictates whether or not the coverage report is uploaded (I am fine with this being a flag as well). |
@zachgersh there's a fair bit of community interest so if you want to submit a PR I think it would be welcome. What changes do you propose to make to ginkgo to achieve your goals above? |
not a huge fan of this honestly, too tightly coupled with coveralls/gover. I'd be more interested in something that combines the individual cover reports and outputs a single file. |
We haven't had any activity on this thread in six months - I'm closing it (again). |
Something like:
ginkgo -cover -coverallsToken=YOUR_TOKEN -coverallsService=travis
The text was updated successfully, but these errors were encountered: