Print correct code location of failing table test #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #515 and #635 for motivation.
Given a test file
Output before this PR:
Output after this PR:
Notes:
TableEntry
directly instead of using one of the(F/P/X)Entry
constructors (as done in theyolo3
example above), the code location of the failingTableEntry
defaults to the surroundingDescribeTable
since I didn't find a way to programmatically locate theTableEntry
. If someone has a good idea, let me know.TableEntry
directly (most users use the(F/P/X)Entry
constructors), the changes in here are backwards compatible if the users use aTableEntry
composite literal with keyed fields. If however, users use aTableEntry
with unkeyed fields (i.e. something likeTableEntry{"yolo3", []interface{}{1}, false, false}
), the changes in this PR will break them. In that case, they would need to name the fields or use the(F/P/X)Entry
constructors.