-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the --focus
flag argument contains metacharacters the test skips.
#786
Comments
hey @joselitofilho - i appreciate the behavior is a bit confusing, but |
I got it @onsi. What do you think? |
My plan here - with v2 over the next couple of months - is to introduce labels. So users can annotate tests with labels and more explicitly control which tests they focus. I assume your usecase has to do with the viscose plugin? For now I'd say you should escape the string in the plug-in. What i'm hoping to do in v2 is offer better support for programmatic interaction with ginkgo. Two ideas:
thoughts on those two ideas? |
That sounds good. 🤓
Yes, it is. For now, I will recommend not using the metacharacters in the name of cases.
I appreciate that two ideas. Helps so much. Especially the second.
Thanks, @onsi. I will close the PR. (or you, if you'd like to close it.) Let me know if you'd like me to help you. |
One more thing. I think the It's just a question to think about. 😃 |
Running this focused test with
--focus="should MyMethod() $called"
:Output:
However, if I running without the
--focus
flag was set it runs.I've been working on it. Can I open a PR for this?
The text was updated successfully, but these errors were encountered: