Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Basemap profile to openmaptiles 3.13.1 #216

Closed
msbarry opened this issue May 6, 2022 · 1 comment · Fixed by #227
Closed

Upgrade Basemap profile to openmaptiles 3.13.1 #216

msbarry opened this issue May 6, 2022 · 1 comment · Fixed by #227

Comments

@msbarry
Copy link
Contributor

msbarry commented May 6, 2022

Release: https://github.com/openmaptiles/openmaptiles/releases/tag/v3.13.1

Changes: openmaptiles/openmaptiles@v3.13...v3.13.1

@msbarry
Copy link
Contributor Author

msbarry commented May 7, 2022

Steps to upgrade:

  • Change 3.13 reference to 3.13.1 in Generate.java and scripts/regenerate-openmaptiles.sh README.md and planetiler-basemap/README.md
  • run scripts/regenerate-openmaptiles.sh
  • Go through the changes to each layer:
    • yaml file changes were applied automatically by the script, you might just need to add/update tests in planetiler-basemap/src/test/java/com/onthegomap/planetiler/basemap/layers based on what changed
    • sql file changes should get reflected in java code/tests in the corresponding layer in planetiler-basemap/src/{main,test}/java/com/onthegomap/planetiler/basemap/layers

I find it's easier to look through the consolidated file diffs instead of individual changes, in case a change was made then reverted/changed later - but sometimes you do need to go back to a PR to understand the intent of a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant